Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support CpusAllowedList for /proc/[pid]/status #490

Merged
merged 2 commits into from May 17, 2023
Merged

add support CpusAllowedList for /proc/[pid]/status #490

merged 2 commits into from May 17, 2023

Conversation

Vatson112
Copy link
Contributor

Hi,

It may be usefull to collect CPU affinity info about processes.

For example, we can monitor:

  • Is out processes running on the same group of cores
  • Is there too many proceeses running on the same group of cores

Tests passes.

@Vatson112
add CpusAllowedList for /proc/[pid]/status
46a6ae7 
Signed-off-by: mn.albeschenko <albeschenko.work@gmail.com>
discordianfish
discordianfish approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

SuperQ
SuperQ reviewed May 5, 2023
View reviewed changes
proc_status.go Outdated Show resolved Hide resolved
SuperQ
SuperQ requested changes May 5, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit about Go comment docs.

@discordianfish @SuperQ
Fix documentation comment
aa83252 
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Johannes 'fish' Ziemke <github@5pi.de>
@discordianfish discordianfish merged commit b5b7dd5 into prometheus:master May 17, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ requested changes

@discordianfish discordianfish discordianfish approved these changes

Assignees

@SuperQ SuperQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vatson112 @discordianfish @SuperQ