Move goautoneg to external dependency #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelolasagasti
force-pushed
the
replace-goautoneg
branch
from
f641647
to
37dc145
Compare
`goautoneg` module was imported to the repo in commit 1f0ade2 as original module was hosted in Bitbucket and required Mercurial at the time (2015). Bitbucket repository is long gone and a GitHub fork is available under `munnerz/goautoneg`. This fork is used by other projects like Kubernetes. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
mikelolasagasti
force-pushed
the
replace-goautoneg
branch
from
c73d234
to
2d5ba4a
Compare
SuperQ
approved these changes
Jun 3, 2024
gotjosh
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM, verified is the same dependency. https://github.com/kubernetes/kubernetes/blob/master/go.mod#L46C1-L47C1
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goautonegmodule was imported to the repo as it was hosted in bitbucket and required Mercurial at the time (2015).Bitbucket repository is long gone and a GitHub fork is available under
munnerz/goautoneg. This fork is used by other projects like Kubernetes.