Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang_protobuf_extensions to v2 #509

Merged

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Aug 15, 2023

  • Updated github.com/matttproud/golang_protobuf_extensions/v2
  • Use common from master in sigv4

matttproud/golang_protobuf_extensions/v2 migrates to using google.golang.org/protobuf instead of the deprecated github.com/golang/protobuf
Helps with #381

@SuperQ
Copy link
Member

SuperQ commented Sep 28, 2023

This needs a rebase.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase.

Updated github.com/matttproud/golang_protobuf_extensions/v2
Use common from master in sigv4

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@Neo2308 Neo2308 force-pushed the feature/master/move-to-protobuf-extensions-v2 branch from 5a6f889 to 6fa8c32 Compare September 28, 2023 08:47
@Neo2308 Neo2308 requested a review from SuperQ September 28, 2023 08:48
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 2dfcc43 into prometheus:main Sep 28, 2023
6 checks passed
@Neo2308 Neo2308 deleted the feature/master/move-to-protobuf-extensions-v2 branch October 9, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants