Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple MetricsSnapshot performance change #963

Merged
merged 1 commit into from
May 23, 2024
Merged

Simple MetricsSnapshot performance change #963

merged 1 commit into from
May 23, 2024
+5 −1

Conversation

dhoard
Copy link
Collaborator

@dhoard dhoard commented May 23, 2024

Simple MetricsSnapshot performance change to prevent calling prometheusName(name) in a loop.

@dhoard
Simple MetricsSnapshot performance change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7578be6 
Signed-off-by: dhoard <doug.hoard@gmail.com>
@dhoard dhoard requested a review from fstab May 23, 2024 11:59
fstab
fstab approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@fstab fstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me!

@fstab fstab merged commit 5867b79 into prometheus:main May 23, 2024
2 checks passed
@dhoard dhoard deleted the metrics-snapshots-performance-improvement branch August 29, 2024 03:32
@burov4j burov4j mentioned this pull request Sep 13, 2024
Merged
This was referenced Oct 15, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstab fstab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhoard @fstab