exp/api: Add accepted msg type validation to handler #1750
Merged
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
bwplotka
approved these changes
Feb 27, 2025
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
ying-jeanne
pushed a commit
to ying-jeanne/client_golang
that referenced
this pull request
Mar 28, 2025
* exp: Add accepted msg type validation to handler Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Apply feedback Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an accepted message arg to NewHandler, to allow callers to limit what remote write messages their servers can handle.