Skip to content

[chore]: enable perfsprint linter #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

perfsprint checks that fmt.Sprintf can be replaced with a faster alternative.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch 2 times, most recently from d673fda to 0bbb0d8 Compare November 8, 2024 07:07
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/perfsprint branch from 0bbb0d8 to 8c1d729 Compare November 8, 2024 07:08
@mmorel-35 mmorel-35 marked this pull request as ready for review November 8, 2024 07:45
@SuperQ SuperQ requested a review from kakkoyun November 8, 2024 08:43
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for noticing and taking care of it.

@kakkoyun kakkoyun merged commit fcfad5c into prometheus:main Nov 8, 2024
10 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/perfsprint branch November 8, 2024 09:05
shivanthzen pushed a commit to shivanthzen/client_golang that referenced this pull request Nov 13, 2024
amberpixels pushed a commit to amberpixels/prometheus_client_golang that referenced this pull request Nov 29, 2024

Verified

This commit was signed with the committer’s verified signature.
webknjaz 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)
Signed-off-by: Eugene <eugene@amberpixels.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants