-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[chore]: enable perfsprint linter #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+67
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d673fda
to
0bbb0d8
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
0bbb0d8
to
8c1d729
Compare
kakkoyun
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for noticing and taking care of it.
shivanthzen
pushed a commit
to shivanthzen/client_golang
that referenced
this pull request
Nov 13, 2024
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Eugene <eugene@amberpixels.io>
This was referenced Feb 19, 2025
Merged
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
This was referenced Apr 13, 2025
Open
1 task
This was referenced Apr 15, 2025
1 task
This was referenced Apr 20, 2025
This was referenced Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
perfsprint checks that fmt.Sprintf can be replaced with a faster alternative.