Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize empty help values in CollectAndCompare #1378

Merged
merged 1 commit into from Nov 20, 2023

Commits on Nov 10, 2023

  1. Normalize empty help values in CollectAndCompare

    Due to an inconsistency in the text protocol between encoding and
    decoding, it was not possible to use the testutil.CollectAndCompare
    function to test metrics with empty help values. To fix this, normalize
    empty help values from the expected/want side of the test so that they
    compare correctly with empty values on the actual/got side of the test.
    
    Signed-off-by: Billy Keyes <bluekeyes@gmail.com>
    bluekeyes committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f746a0e View commit details
    Browse the repository at this point in the history