Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifier: Webex #3132

Merged
merged 11 commits into from
Dec 15, 2022
Merged

Notifier: Webex #3132

merged 11 commits into from
Dec 15, 2022

Commits on Nov 9, 2022

  1. Notifier: Webex 

    Cisco's Webex has been one of the most requested notifiers on Grafana for a while now, please see: grafana/grafana#11750 (comment)

Given it's straightforward implementation, low maintance overhead and request demand, I think it's worth including this directly in the Alertmanager.

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9e2608e View commit details
    Browse the repository at this point in the history

  2. A few changes to better align with what I know think it's the best se… 

    …tup in Webex Teams

- Move away from Webhook to APIRUL
- Make the Room ID a require field
- Set Authorization Credentails via Headers

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ac0dc96 View commit details
    Browse the repository at this point in the history

  3. Fix and add a new test 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    e8b5c0a View commit details
    Browse the repository at this point in the history

  4. Validate that either bot_token or http_configs.authorization must be … 

    …present

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    7f94b16 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Use the new truncation in bytes functions to ensure strings are not b… 

    …utchered

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f51f51e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Change duplicated tags 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    2c9eb98 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Rename message to markwdown on the webex notifier 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5ebe94d View commit details
    Browse the repository at this point in the history

  2. Add the webex documentation 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    02660ba View commit details
    Browse the repository at this point in the history

  3. Remove the bot_token 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    572de99 View commit details
    Browse the repository at this point in the history

  4. Remove the dedicated field to APIURL in favour of the configuration one 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1ba6405 View commit details
    Browse the repository at this point in the history

  5. Doc changes requested by review 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c3aaca8 View commit details
    Browse the repository at this point in the history