EmailConfig: Use CanonicalMIMEHeaderKey instead of TitleCasing for headers #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aders Fixes prometheus#3064. Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>
joeblubaugh
force-pushed
the
joe/3064/fix-mime-header-casing
branch
from
513ea60
to
289de2a
Compare
Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>
|
@simonpasquier how and when do commits get tagged as releases? Is there's a process that we can help with? I'd like to import this change into some downstream projects. |
|
@joeblubaugh we have no fixed schedule for releases but I'm planning on preparing a 0.25 release candidate soon-ish. |
|
Great, thank you. |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
…aders (prometheus#3080) * EmailConfig: Use CanonicalMIMEHeaderKey instead of TitleCasing for headers Fixes prometheus#3064. Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com> * Remove an unused field. Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com> Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3064.