Alertmanager: Update the prometheus/alertmanager to its latest version #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pracucci could you please take a look? 🙏 Would love if this could make it to next week's build. |
|
Sure @gotjosh. Looking into it. |
pracucci
reviewed
Sep 30, 2022
There was a problem hiding this comment.
This Alertmanager upgrade introduces two new settings which allow to read from file and send it content over the network:
- GlobalConfig > SMTPAuthPasswordFile
- EmailConfig > AuthPasswordFile
Similar configs are blocked in Mimir, because of security reasons. We should block these two new settings too. Please look at validateAlertmanagerConfig() and its test TestValidateAlertmanagerConfig.
- github.com/aws/aws-sdk-go v1.44.66 // indirect
+ github.com/aws/aws-sdk-go v1.44.94 // indirectI went through the AWS release notes and everything looks good to me. |
gotjosh
commented
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrades alertmanager to its latest version.
Which issue(s) this PR fixes or relates to
Fixes #2651, which was fixed via prometheus/alertmanager#2968
Fixes #2806
A revert of #2924, which was fixed via prometheus/alertmanager#3080
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]