Merge pull request #2968 from prometheus/parse-matchers-empty-value

Ensure matcher values are present when parsing matchers from strings
prometheus · Sep 30, 2022 · 5455296 · 5455296
2 parents 0a9a48d + bd89550
commit 5455296
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pkg/labels/parse.go b/pkg/labels/parse.go
@@ -127,7 +127,7 @@ func ParseMatcher(s string) (_ *Matcher, err error) {
 		expectTrailingQuote bool
 	)
 
-	if rawValue[0] == '"' {
+	if strings.HasPrefix(rawValue, "\"") {
 		rawValue = strings.TrimPrefix(rawValue, "\"")
 		expectTrailingQuote = true
 	}

diff --git a/pkg/labels/parse_test.go b/pkg/labels/parse_test.go
@@ -189,6 +189,13 @@ func TestMatchers(t *testing.T) {
 				return append(ms, m, m2)
 			}(),
 		},
+		{
+			input: `job=`,
+			want: func() []*Matcher {
+				m, _ := NewMatcher(MatchEqual, "job", "")
+				return []*Matcher{m}
+			}(),
+		},
 		{
 			input: `job="value`,
 			err:   `matcher value contains unescaped double quote: "value`,