Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] add tpl to prometheus service account #4900

Conversation

denzhel
Copy link
Contributor

@denzhel denzhel commented Oct 6, 2024

What this PR does / why we need it

We're moving our infra charts from Terraform to ArgoCD/ApplicationSets and we need the ability to template
some values with an environment name, accountID and etc ...

In this case, we need the ability to template the service account and inject account id and environment name to the IAM role ARN

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Dennis Zheleznyak <dennis@bigpanda.io>
@jkroepke jkroepke merged commit 3b1a86e into prometheus-community:main Oct 6, 2024
4 checks passed
@jkroepke
Copy link
Member

jkroepke commented Oct 6, 2024

Thanks

@denzhel denzhel deleted the kube-prometheus-stack-prom-svc-account-tpl branch October 7, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants