Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] add prometheus label "pod" to etcd alerts #4891

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

jusch23
Copy link
Contributor

@jusch23 jusch23 commented Oct 2, 2024

What this PR does / why we need it

Modifies sync_prometheus_rules.py script to add prometheus label "pod" to etcd instance labels.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
… alerts on downtime of one etcd member (#2720)

Signed-off-by: Julian Schreiner <20794518+jusch23@users.noreply.github.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
QMalcolm Quigley Malcolm
Signed-off-by: Julian Schreiner <20794518+jusch23@users.noreply.github.com>
Signed-off-by: Julian Schreiner <20794518+jusch23@users.noreply.github.com>
Signed-off-by: Julian Schreiner <20794518+jusch23@users.noreply.github.com>
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@QuentinBisson QuentinBisson merged commit aa3d8bc into prometheus-community:main Oct 8, 2024
4 checks passed
This was referenced Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kube-prometheus-stack] Unexpected alerts firing - Why?
3 participants