Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ErrNoMoreRequests for generator #3918

Merged
merged 3 commits into from
Jul 12, 2023
Merged

add ErrNoMoreRequests for generator #3918

merged 3 commits into from
Jul 12, 2023

Conversation

tarunKoyalwar
Copy link
Member

No description provided.

@tarunKoyalwar tarunKoyalwar self-assigned this Jul 10, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Jul 10, 2023 that may be closed by this pull request
@ehsandeep ehsandeep marked this pull request as ready for review July 11, 2023 23:40
@ehsandeep ehsandeep requested a review from Mzack9999 July 11, 2023 23:41
@ehsandeep ehsandeep linked an issue Jul 11, 2023 that may be closed by this pull request
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
The issue was related to a template containing a space in the path, anyway great simplification!

Note: what about simply cloning to destination-base-folder/repo-owner/repo-name literally as in GitHub

@Mzack9999 Mzack9999 requested a review from ehsandeep July 12, 2023 15:21
@tarunKoyalwar
Copy link
Member Author

@Mzack9999 yeah i think that's what we should have done from the beginning .(😄 even go mod does the same) . but i think changing dir structure will be breaking change to custom templates . since update/existing custom templates won't work properly

@ehsandeep
Copy link
Member

@Mzack9999 yeah i think that's what we should have done from the beginning .(😄 even go mod does the same) . but i think changing dir structure will be breaking change to custom templates . since update/existing custom templates won't work properly

We can do it with the next major release - tracked at #3925

@ehsandeep ehsandeep merged commit d51e058 into dev Jul 12, 2023
11 checks passed
@ehsandeep ehsandeep deleted the issue-3905-fuzzing-err branch July 12, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants