Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support disable-path-automerge in unsafe mode #3888

Merged
merged 4 commits into from
Jul 4, 2023
Merged

support disable-path-automerge in unsafe mode #3888

merged 4 commits into from
Jul 4, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jun 29, 2023 •
edited

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M linked an issue Jun 29, 2023 that may be closed by this pull request
support for disable-path-automerge in unsafe mode #3848
Closed
@RamanaReddy0M RamanaReddy0M self-assigned this Jun 29, 2023
@RamanaReddy0M RamanaReddy0M added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 29, 2023
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 3, 2023
tarunKoyalwar
tarunKoyalwar approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

$ ./nuclei -u "scanme.sh/api/v2/?yes=do" -t ~/test-templates/unsafe-path-merge.yaml -debug-req

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.9.7

		projectdiscovery.io

[INF] Current nuclei version: v2.9.7 (outdated)
[INF] Current nuclei-templates version: v9.5.4 (latest)
[INF] New templates added in latest release: 51
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[INF] [test] Dumped HTTP request for https://scanme.sh/api/v1/id=123?yes=do

GET /api/v1/id=123?yes=do HTTP/1.1
Host: scanme.sh

[test] [http] [info] https://scanme.sh/api/v1/id=123?yes=do

@ehsandeep ehsandeep merged commit 1eb4c7c into dev Jul 4, 2023
11 checks passed
@ehsandeep ehsandeep deleted the issue-3848-disable-path-auto-merge-in-unsafe-mode branch July 4, 2023 13:34
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for disable-path-automerge in unsafe mode
3 participants
@RamanaReddy0M @ehsandeep @tarunKoyalwar