Don't fail on citations when the 700 only has punctuation and spaces #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
jcoyne
requested changes
Feb 29, 2024
| @@ -572,6 +573,7 @@ def name_reverse(name) | |||
| name = clean_end_punctuation(name) | |||
| return name unless name =~ /,/ | |||
| temp_name = name.split(", ") | |||
| return name if temp_name.empty? | |||
There was a problem hiding this comment.
Does this handle some case other than name = ", "? If so, can we just look for that on line 574? Otherwise, would you mind adding some comments to explain what we're looking for?
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
jcoyne
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a catalog record that has a 700#a ", ." that caused errors.