-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): dynamodb implementation #953
Conversation
56e7f57
to
e360e37
Compare
7e053e8
to
7a515b1
Compare
3c1a9e4
to
aa9db8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 74 74
Lines 14128 14128
=======================================
Hits 12488 12488
Misses 1277 1277
Partials 363 363 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6540e04
to
863e6f0
Compare
72a5ac3
to
ebb0c99
Compare
let's add a new testCase in TestS3Dedupe https://github.com/project-zot/zot/blob/main/pkg/storage/s3/s3_test.go#L935 Currently TestS3Dedupe it's using boltdb, let's use both boltdb and DynamoDB, this should be a small change. |
ebb0c99
to
b2a8eeb
Compare
Thanks for tracking your PR with task items, makes it easier to follow. |
2c0890c
to
c9768ff
Compare
d2ab7c3
to
07d5cea
Compare
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
07d5cea
to
1726069
Compare
What type of PR is this?
enhancement
Which issue does this PR fix:
Part of #564
What does this PR do / Why do we need it:
Added AWS DynamoDB driver.
Will this break upgrades or downgrades?
If a client uses DynamoDB and decides to downgrade, they must make sure that the database is migrated to BoltDB to avoid data loss.
New validations that might break stuff:
local storage driver, but explicit RemoteCache=true, this is not valid, so error out
remote storage driver, but no "cacheDriver" config section, error out
Defaults:
local storage driver -> RemoteCache=false
remote storage driver (s3) -> RemoteCache=true
Does this PR introduce any user-facing change?:
Adds the possibility to use AWS DynamoDB instead of BoltDB
Problems
To do
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.