-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function for listing lqs by flavors #710
add function for listing lqs by flavors #710
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 93.99% 94.06% +0.07%
==========================================
Files 36 36
Lines 2364 2394 +30
==========================================
+ Hits 2222 2252 +30
Misses 142 142 ☔ View full report in Codecov by Sentry. |
7bbdc70
to
905d556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KPostOffice Can you provide some verification steps? I am going to take a stab at testing this and I want to make sure I am setting up my environment correctly.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a simple import for this function?
Signed-off-by: Kevin <kpostlet@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KPostOffice Works perfectly couple of notes.
- Failed on my cluster with regular user possibly because I am using an independent Kueue deployment. (verified a regular user can see localqueues on another clean cluster)
/lgmt /approve
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b7c37af
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-13429
What changes have been made
This lists local queues available to a user as well as the flavors for that LQ if available
Verification steps
make and deploy kueue with latest changes from opendatahub-io/kueue#52
Create Flavors, LQs, and CQ
will update with more details when cluster resumes
Checks