Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Kueue module #696

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Refactor Kueue module #696

merged 1 commit into from
Oct 4, 2024
+93 −70

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 2, 2024 •
edited
Loading

Issue link

Closes: RHOAIENG-13331

What changes have been made

Refactored the Kueue module to fit the design doc

Verification steps

E2E and Unit tests should be sufficient

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@Ygnas Ygnas added the test-guided-notebooks Run PR check to verify Guided notebooks label Oct 2, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2024
@Ygnas Ygnas marked this pull request as ready for review October 3, 2024 09:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
@Ygnas Ygnas added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 3, 2024
@Bobbins228 Bobbins228 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
Bobbins228
Bobbins228 reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm happy to merge when preceding PR is 👍

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@Ygnas Ygnas added test-guided-notebooks Run PR check to verify Guided notebooks and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 4, 2024
@Ygnas Ygnas added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 4, 2024
@Ygnas Ygnas requested a review from Bobbins228 October 4, 2024 08:15
@Ygnas Ygnas force-pushed the RHOAIENG-13331 branch 2 times, most recently from 23d0fa6 to 2d51728 Compare October 4, 2024 08:17
@Ygnas Ygnas added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 4, 2024
@Ygnas Ygnas added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 4, 2024
ChristianZaccaria
ChristianZaccaria reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm just a non-blocking nitpick. - Good for merge

@Ygnas
Refactor: kueue module
Loading
Loading status checks…
2b3835e
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@ChristianZaccaria
Copy link
Collaborator

/lgtm

@Bobbins228 Bobbins228 added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 4, 2024
Bobbins228
Bobbins228 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ffbdfec into project-codeflare:main Oct 4, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228

@ChristianZaccaria ChristianZaccaria

@KPostOffice KPostOffice

@varshaprasad96 varshaprasad96

Assignees

@Bobbins228 Bobbins228

@ChristianZaccaria ChristianZaccaria

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ygnas @ChristianZaccaria @Bobbins228 @openshift-merge-robot