-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove installation of packages in nb sync #690
remove installation of packages in nb sync #690
Conversation
Signed-off-by: Kevin <kpostlet@redhat.com>
e7c093a
to
cbaadaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jstourac: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dc4f2f1
into
project-codeflare:main
Just realized - without this, the Pipfile.lock isn't updated, is it? 🤔 Didn't check whether there is some call elsewhere in the file now. Update: I commented yesterday on my way out already, so I checked properly now. It's good, Pipfile.lock will be updated on this line https://github.com/project-codeflare/codeflare-sdk/pull/690/files#diff-22734aa74fc5a41e0fa73ccdcaf804ad0bd18e14e9c31cf6e181ec1e6c0916b5R68 . |
What changes have been made
remove line doing CF-SDK installation just lock with new dependency
Verification steps
Checks