Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove installation of packages in nb sync #690

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

KPostOffice
Copy link
Collaborator

What changes have been made

remove line doing CF-SDK installation just lock with new dependency

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Sorry, something went wrong.

Signed-off-by: Kevin <kpostlet@redhat.com>
@KPostOffice KPostOffice added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 1, 2024
Copy link
Contributor

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@jstourac: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dc4f2f1 into project-codeflare:main Oct 1, 2024
8 checks passed
@jstourac
Copy link
Contributor

jstourac commented Oct 1, 2024

Just realized - without this, the Pipfile.lock isn't updated, is it? 🤔 Didn't check whether there is some call elsewhere in the file now.

Update: I commented yesterday on my way out already, so I checked properly now. It's good, Pipfile.lock will be updated on this line https://github.com/project-codeflare/codeflare-sdk/pull/690/files#diff-22734aa74fc5a41e0fa73ccdcaf804ad0bd18e14e9c31cf6e181ec1e6c0916b5R68 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants