fix: parse "TLOAD/TSTORE" correctly in trace #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-eth-types
han0110
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Seems like TLOAD/TSTORE are updated to 0x5c and 0x5d
See ethereum/go-ethereum#27613 and https://eips.ethereum.org/EIPS/eip-1153
Also perhaps we could handle MCOPY (0x5e) and BLOBBASEFEE (0x4a) in the same way in this PR.
|
the geth inside geth-utils is v1.11.5, earlier than ethereum/go-ethereum#27613. So either temporarily keep using 0xb3/0xb4, or upgrade geth and change TSTORE/TLOAD opcode. |
There was a problem hiding this comment.
Does this fix correspond to the bugs like badOpcodes_d49_g0_v0 in the Ethereum tests?
It is intended to fix the following error message, right?
Exception(expected:false, found:"SerdeError(Error(\"OpcodeParsing(\\\"TLOAD\\\")\", line: 108, column: 21))")
ChihChengLiang
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0xb3 / 0xb4 are rendered as "TLOAD/TSTORE" in geth trace json.
Issue Link
[link issue here]
Type of change