feat(client): Add omit option to the queries
#23770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
commented
Apr 8, 2024
size-limit report 📦
|
CodSpeed Performance ReportMerging #23770 will not alter performanceComparing Summary
|
SevInf
commented
Apr 8, 2024
SevInf
force-pushed
the
exclude
branch
2 times, most recently
from
c2efb08
to
0cd2f25
Compare
SevInf
commented
Apr 9, 2024
packages/client/src/runtime/core/errorRendering/applyValidationError.test.ts
Show resolved
Hide resolved
|
Note: tests are failing because #23813 needs integration first, it should not block the review though. |
SevInf
commented
Apr 10, 2024
Druue
reviewed
Apr 10, 2024
packages/client/src/runtime/core/jsonProtocol/serializeJsonQuery.ts
Outdated
Show resolved
Hide resolved
packages/client/src/runtime/core/errorRendering/applyValidationError.ts
Outdated
Show resolved
Hide resolved
Druue
reviewed
Apr 10, 2024
Druue
reviewed
Apr 10, 2024
Druue
approved these changes
Apr 10, 2024
SevInf
changed the title
exclude option to the queriesomit option to the queries
SevInf
force-pushed
the
exclude
branch
3 times, most recently
from
910dc00
to
9a11913
Compare
SevInf
commented
Apr 12, 2024
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Counterpart to prisma/prisma-engines#4807 Can be used standalone or combined with `include`, allows to exclude the fields that normally would be included by default. Available in all methods that return actual database records. It is not useable together with `select` and attempt to do so would cause type check and validation error. When using together with result extensions, excluded dependency of a computed field will be queried from a DB, but will not be returned to the end user, unless computed field is exlucded as well (see "exclude with extensions" tests in this PR). This behaviour is equivalent to what we do if depenency of a computed field is not mentioned in explicit `select`. Close prisma/team-orm#1080
|
Client memory tests, node 18, library: ✅ Success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to prisma/prisma-engines#4807
Can be used standalone or combined with
include, allows to excludethe fields that normally would be included by default. Available in all
methods that return actual database records.
It is not useable together with
selectand attempt to do so wouldcause type check and validation error.
When using together with result extensions, excluded dependency of a
computed field will be queried from a DB, but will not be returned to
the end user, unless computed field is exlucded as well (see "omit
with extensions" tests in this PR). This behaviour is equivalent to what
we do if depenency of a computed field is not mentioned in explicit
select.TODO:
Close prisma/team-orm#1080
#5042
/integration