New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump prettier
and eslint-plugin-prettier
#20181
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: prettier@2.8.8 |
CodSpeed Performance ReportMerging #20181 will degrade performances by 45.68%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrazauskas for the PR 💚
@Jolg42 Sorry, I forgot one detail. Current, if Prettier v3 is installed, Jest fails to update inline snapshots. There are two solutions:
What would you prefer? As you see in CI, all works with existing snaps. The problem accrues if they have to be updated or created. Reference: jestjs/jest#14305 |
Ouch 😢 It sounds to me like reverting is easier/best until this is figured out then. |
PR created from "Revert" UI button #20182 |
Agreed. I will come back after the issue is fixed on Jest side. |
Thank you! |
Now Jest will error in next version Tracking issue to monitor |
Closes #20082
Closes #20179
prettier
andeslint-plugin-prettier
should be updated together. Since this is major version ofprettier
, there are few changes in formatting.