Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectPanel] Fix result count in screen reader announcements #3187

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Nov 8, 2024

What are you trying to accomplish?

This PR fixes an issue causing SelectPanels to announce an incorrect number of items after filtering. It also switches to using the awesome <live-region> element.

Integration

No changes necessary in production.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/4369

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I changed the code to only consider visible items, and switched to the <live-region> element: https://github.com/primer/live-region-element.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Sorry, something went wrong.

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 03f4e83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron changed the title Select panel announcements [SelectPanel] Fix result count in screen reader announcements Nov 8, 2024
@camertron camertron marked this pull request as ready for review November 18, 2024 17:41
@camertron camertron requested a review from a team as a code owner November 18, 2024 17:41
@camertron camertron requested review from TylerJDev and jonrohan and removed request for TylerJDev November 18, 2024 17:41
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@camertron camertron merged commit a91aa93 into main Nov 19, 2024
34 checks passed
@camertron camertron deleted the select_panel_announcements branch November 19, 2024 18:14
@primer primer bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants