Update the primer/primitives dependency to be 9.x || 10.x and move it to peer #3179
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to peer Update the `@primer/primitives` dependency to `9.x || 10.x` and move it to peer dependencies. * **demo/package.json** - Update the `@primer/primitives` version to `9.x || 10.x`. - Move the `@primer/primitives` entry from `dependencies` to `peerDependencies`. * **package.json** - Update the `@primer/primitives` version to `9.x || 10.x`. - Move the `@primer/primitives` entry from `dependencies` to `peerDependencies`. * **package-lock.json** - Update the `@primer/primitives` version to `9.x || 10.x`. - Add `peerDependencies` section with `@primer/primitives` entry. * **demo/package-lock.json** - Update the `@primer/primitives` version to `9.x || 10.x`. - Add `peerDependencies` section with `@primer/primitives` entry. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/primer/view_components?shareId=XXXX-XXXX-XXXX-XXXX).
🦋 Changeset detectedLatest commit: 9bc95c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* Remove `@primer/primitives` entry from `dependencies` section
jonrohan
reviewed
Nov 4, 2024
demo/package.json
Outdated
| "@rails/actioncable": "^7.2.100", | ||
| "@rails/ujs": "^7.1.400", | ||
| "turbolinks": "^5.2.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@primer/primitives": "9.x || 10.x" | ||
| }, |
There was a problem hiding this comment.
This change in the demo isn't necessary since we don't publish this package, it only effects what's being used in the lookbook
camertron
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4326
Update the
@primer/primitivesdependency to9.x || 10.xand move it to peer dependencies.package.json
@primer/primitivesversion to9.x || 10.x.@primer/primitivesentry fromdependenciestopeerDependencies.package-lock.json
@primer/primitivesversion to9.x || 10.x.peerDependenciessection with@primer/primitivesentry.For more details, open the Copilot Workspace session.