Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio): update ordering of selectors for checked options #5765

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

joshblack
Copy link
Member

Closes #5672

Update the ordering of our CSS selectors for Radio so that checked was not rendering incorrectly due to a later selector with same specificity winning out.

Changelog

New

Changed

  • Change the ordering of CSS for Radio so that the checked styles were not overridden

Removed

Rollout strategy

  • Patch release

Sorry, something went wrong.

@joshblack joshblack requested a review from a team as a code owner March 11, 2025 21:02
@joshblack joshblack requested a review from TylerJDev March 11, 2025 21:02
Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: f9d9c15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Mar 11, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 11, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.06 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 106.41 KB (-0.1% 🔽)

@primer primer bot requested a review from a team as a code owner March 14, 2025 15:32
@primer primer bot requested a review from emilybrick March 14, 2025 15:32
@github-actions github-actions bot temporarily deployed to storybook-preview-5765 March 14, 2025 15:35 Inactive
@joshblack joshblack enabled auto-merge March 14, 2025 15:40
@joshblack joshblack added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 86a6211 Mar 14, 2025
44 checks passed
@joshblack joshblack deleted the fix/update-radio-checked-styles branch March 14, 2025 15:57
@primer primer bot mentioned this pull request Mar 14, 2025
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
Co-authored-by: joshblack <joshblack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checked radio does not display properly
2 participants