fix(TextInput): use cursor text on wrapper #5733
Merged
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb54035 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
joshblack
approved these changes
Mar 4, 2025
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/365293 |
…om:primer/react into 4816-mouse-cursor-not-updated-if-sizelarge
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hectahertz
pushed a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4816
Fixes bug where TextInput size large was displaying cursor type pointer when hovered over the edges because it wasn't hovering the input, but the wrapper span. Adds cursor type text to span.
Changelog
New
Rollout strategy
Testing & Reviewing
Merge checklist