Fixes AvatarStack styling bugs (focus on stacking context issues) #5714
+181
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b673ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
13 tasks
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@mperrotti I reviewed this with macOS VoiceOver, NVDA, and JAWS. CSS' |
hectahertz
approved these changes
Feb 24, 2025
Comment on lines
+129
to
+132
| // MIN-WIDTH CALC FORMULA EXPLAINED: | ||
| // avatar size ➡️ var(--avatar-stack-size) | ||
| // plus the visible part of the 2nd avatar ➡️ var(--avatar-stack-size) - var(--overlap-size) | ||
| // plus the visible part of the 3rd AND 4th avatar ➡️ (var(--avatar-stack-size) - var(--overlap-size-avatar-three-plus)) * 2 |
There was a problem hiding this comment.
Really well explained, thanks
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mperrotti
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-actions
bot
requested a deployment
to
storybook-preview-5714
github-actions
bot
requested a deployment
to
storybook-preview-5714
github-actions
bot
requested a deployment
to
storybook-preview-5714
github-actions
bot
requested a deployment
to
storybook-preview-5714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/copilot-productivity/issues/3985
An alternative approach: #5705
Benefits of this approach:
AvatarStackcan now be used on any background color without seeing thevar(--bgColor-default)border around each avatardirectionproperty to remove redundant styles and!importantflagsDemos
Both demos are zoomed in x10.
Before
Kapture.2025-02-19.at.17.58.16.mp4
After
Kapture.2025-02-19.at.18.00.52.mp4
Changelog
New
Changed
Replaces
z-indexandbox-shadowAvatarStack styling withmaskRemoved
Rollout strategy
Testing & Reviewing
Merge checklist