Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FormControl): Move FormControl css modules feature flag from team to staff #5669

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 7, 2025

Changelog

New

Changed

Move FormControl css modules feature flag from team to staff

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

This shouldn't require any testing. Verify no open bug FormControl issues before shipping.

Merge checklist

Sorry, something went wrong.

@jonrohan jonrohan requested a review from a team as a code owner February 7, 2025 19:16
@jonrohan jonrohan requested a review from mperrotti February 7, 2025 19:16
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 1d2fad6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Feb 7, 2025
@jonrohan jonrohan enabled auto-merge February 7, 2025 19:16
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@jonrohan jonrohan requested review from TylerJDev and removed request for mperrotti February 7, 2025 19:16
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.61 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 105.97 KB (-0.11% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-5669 February 7, 2025 19:19 Abandoned
@jonrohan jonrohan added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit b2bc006 Feb 7, 2025
44 checks passed
@jonrohan jonrohan deleted the css_modules_formcontrol_staff branch February 7, 2025 19:41
@primer primer bot mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants