Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubNav: Add aria-current to SubNav #5661

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Feb 5, 2025

Closes https://github.com/github/primer/issues/3433

Context: https://github.com/github/accessibility-audits/issues/10093

Changelog

New

  • Add aria-current to SubNav.Link

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Sorry, something went wrong.

@TylerJDev TylerJDev requested a review from a team as a code owner February 5, 2025 14:53
@TylerJDev TylerJDev requested a review from mperrotti February 5, 2025 14:53
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 657fc31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.69 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js 106.01 KB (-0.03% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5661 February 5, 2025 15:07 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot temporarily deployed to storybook-preview-5661 February 5, 2025 15:25 Inactive
@TylerJDev TylerJDev changed the title Add aria-current to SubNav SubNav: Add aria-current to SubNav Feb 5, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5661 February 5, 2025 15:39 Inactive
@TylerJDev TylerJDev added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5661 February 13, 2025 18:34 Inactive
@TylerJDev TylerJDev added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 1262f5a Feb 13, 2025
44 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-aria-current-to-subnav branch February 13, 2025 18:55
@primer primer bot mentioned this pull request Feb 13, 2025
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
* Add `aria-current` to `SubNav`

* Add changeset

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants