-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expand to NavList
#4686
Add expand to NavList
#4686
Conversation
🦋 Changeset detectedLatest commit: d22f63f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on putting this together! Just left a comment but approving since it's non-blocking 👍
Co-authored-by: Josh Black <joshblack@github.com>
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/363691 |
🟢 golden-jobs completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
* Add expand to `NavList` * Improved semantics * Remove styles * Add extra story * Add unit test coverage * Add Group unit test coverage * Add e2e test coverage * Add expanded to groups * Fix import * Change structure * Update stories, add ref * Update tests, add focus target * Add changeset * Remove `GroupContent` * Update to use context * Add useRef usage * Change name to `NavList.ShowMoreItem` * Update docs * test(vrt): update snapshots * Update .changeset/many-rivers-deny.md Co-authored-by: Josh Black <joshblack@github.com> * Address some feedback * Memoize id value * Update w/ new prop `Pages` based on suggestion from Primer patterns * test(vrt): update snapshots * Remove story * Remove story test * Remove the correct story * Add condition for css modules feature flag * Update tests, docs, add ternary * Only allow for `Item` in `ShowMoreItem` * Fix lint issue * Add dependencies * Remove comment * Add data API * Some clean up for `NavList` * More clean up * Use `useMemo` instead * Update docs * Fix tests * Remove auto-import * Add `key` to story * PR review feedback * Type check * Update packages/react/src/NavList/NavList.tsx Co-authored-by: Josh Black <joshblack@github.com> --------- Co-authored-by: Kate Higa <16447748+khiga8@users.noreply.github.com> Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com>
Adds new component
NavList.ShowMoreItem
, allows native support for "expanding" content within aNavList
.Closes https://github.com/github/primer/issues/2637
Proposed API
Basic example:
Multiple expands:
Group example (storybook)
Changelog
New
NavList.ShowMoreItem
Rollout strategy
Testing & Reviewing
Merge checklist