-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionList: Allow items to remain focusable when disabled #4481
Conversation
… `disabled`
🦋 Changeset detectedLatest commit: 09101fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Should require only one change in Dotcom (a modification to a test), other than that it appears that the tests related to this change pass. |
That's great! It looks like we can only make the dotcom change after merging this PR, correct? |
@siddharthkp, yup that should be it! |
This PR should be ready for a review! cc: @primer/engineer-reviewers |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359651 |
🔴 golden-jobs completed with status |
Allows
disabled
items inActionMenu
andSelectPanel
to remain focusable. This stems from feedback we've received from the Accessibility Team.Changelog
Integration test PR: https://github.com/github/github/pull/324056
Passes with small modifications (minus flakey tests), requires only one change to a test in Dotcom.
Changed
ActionList.Item
to keep focus if it's within anActionMenu
orSelectPanel
context.Rollout strategy
Testing & Reviewing
Merge checklist