Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: primer/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @primer/react@37.8.0
Choose a base ref
...
head repository: primer/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @primer/react@37.9.0
Choose a head ref

Commits on Dec 13, 2024

  1. chore(TreeView): Move TreeView component css module feature flag to s…

    …taff (#5388)
    
    * Move TreeView to staff
    
    * Create many-pans-tickle.md
    jonrohan authored Dec 13, 2024
    Copy the full SHA
    e3856ba View commit details
  2. chore(Breadcrumbs): Move Breadcrumbs component css module feature fla…

    …g to staff (#5387)
    
    * Move Breadcrumbs to staff
    
    * Create shaggy-geese-smile.md
    jonrohan authored Dec 13, 2024
    Copy the full SHA
    e29c40c View commit details
  3. chore(Skeleton): Move Skeleton component css module feature flag to ga (

    #5382)
    
    * Move Skeleton components to ga
    
    * Create eight-guests-punch.md
    jonrohan authored Dec 13, 2024
    Copy the full SHA
    83607df View commit details
  4. test(e2e): add snapshots for DataTable stories (#5437)

    * test(e2e): add snapshots for DataTable stories
    
    * test: add mask for relative time elements
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: joshblack <joshblack@users.noreply.github.com>
    joshblack and joshblack authored Dec 13, 2024
    Copy the full SHA
    280871d View commit details
  5. chore(deps): update @primer/primitives to 10.2.0 (#5440)

    * chore(deps): update @primer/primitives to 10.2.0
    
    * add tests
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    3 people authored Dec 13, 2024
    Copy the full SHA
    9cea3df View commit details

Commits on Dec 16, 2024

  1. chore(Select): Move Select component css module feature flag to ga (#…

    …5386)
    
    * Move Select componet to ga
    
    * Create kind-phones-drop.md
    jonrohan authored Dec 16, 2024
    Copy the full SHA
    177eadc View commit details
  2. chore(Stack): Move Stack component css module feature flag to ga (#5384)

    * Move Stack to ga feature flag
    
    * Create plenty-tools-count.md
    jonrohan authored Dec 16, 2024
    Copy the full SHA
    eedbdbd View commit details
  3. chore(Header): Move Header component css module feature flag to ga (#…

    …5380)
    
    * Move Header component to GA
    
    * Create shiny-horses-promise.md
    jonrohan authored Dec 16, 2024
    Copy the full SHA
    fcc041d View commit details
  4. Add priority to Storybook className override tests (#5447)

    * important
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    langermank and langermank authored Dec 16, 2024
    Copy the full SHA
    f9e193b View commit details

Commits on Dec 17, 2024

  1. feat(BaseStyles): Fix Typography and Common props when CSS modules fe…

    …ature flag is enabled (#5444)
    
    * Fix Typography and Common props for BaseStyles behind feature flag
    
    * Update Text to use util includesSystemProps
    
    * Fix whiteSpace prop for BaseStyles
    
    * Add changeset
    
    * Fix color ts error
    
    * Updated color variable in AnchoredOverlay
    JelloBagel authored Dec 17, 2024
    Copy the full SHA
    8e481ca View commit details
  2. Bug fix: ButtonGroup with Tooltips (#5123)

    * messy stuff
    
    * fix loading button group styles
    
    * lint
    
    * Create clean-camels-train.md
    
    * remove button changes
    
    * fix(TooltipV2): check for interactive content two levels down
    
    * empty case
    
    * add test
    
    * lint
    
    * test sxprop change
    
    * revert for separate pr
    
    * test(vrt): update snapshots
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: Armagan Ersoz <broccolinisoup@github.com>
    Co-authored-by: Marie Lucca <francinelucca@github.com>
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    Co-authored-by: Jon Rohan <yes@jonrohan.codes>
    5 people authored Dec 17, 2024
    Copy the full SHA
    becad7d View commit details
  3. test(AutoComplete): add e2e tests (#5417)

    * test(AutoComplete): add e2e tests
    
    * test(vrt): update snapshots
    
    * fix(Autocomplete): wait for full render before e2e testing
    
    * test(vrt): update snapshots
    
    * fix dev storybook accessibility
    
    * fix lint
    
    * fix theme related a11y errors
    
    * test(vrt): update snapshots
    
    * ignore color-contrast rule
    
    * add aria-label to dialog
    
    * fix tests maybe?
    
    * remove playground snaps
    
    * test(vrt): update snapshots
    
    * retry mask
    
    * fix contrast failure
    
    * try to disable flaky test
    
    * test(vrt): update snapshots
    
    * remove rule
    
    * fix vrt test
    
    * format fix
    
    * update assertion
    
    * test(vrt): update snapshots
    
    * disable aria rule
    
    * add label
    
    ---------
    
    Co-authored-by: francinelucca <francinelucca@users.noreply.github.com>
    Co-authored-by: Randall Krauskopf <104226843+randall-krauskopf@users.noreply.github.com>
    Co-authored-by: randall-krauskopf <randall-krauskopf@users.noreply.github.com>
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    Co-authored-by: Hussam Ghazzi <hussam-i-am@github.com>
    Co-authored-by: hussam-i-am <hussam-i-am@users.noreply.github.com>
    8 people authored Dec 17, 2024
    Copy the full SHA
    bd568fd View commit details

Commits on Dec 18, 2024

  1. feat(Autocomplete): Convert to CSS modules behind feature flag (#5453)

    * test(AutoComplete): add e2e tests
    
    * test(vrt): update snapshots
    
    * fix(Autocomplete): wait for full render before e2e testing
    
    * test(vrt): update snapshots
    
    * fix dev storybook accessibility
    
    * fix lint
    
    * fix theme related a11y errors
    
    * test(vrt): update snapshots
    
    * ignore color-contrast rule
    
    * add aria-label to dialog
    
    * fix tests maybe?
    
    * remove playground snaps
    
    * test(vrt): update snapshots
    
    * retry mask
    
    * fix contrast failure
    
    * try to disable flaky test
    
    * test(vrt): update snapshots
    
    * feat(Autocomplete): Convert to CSS modules behind feature flag
    
    * remove rule
    
    * fix vrt test
    
    * format fix
    
    * update assertion
    
    * test(vrt): update snapshots
    
    * disable aria rule
    
    * add label
    
    * format fix
    
    ---------
    
    Co-authored-by: Marie Lucca <francinelucca@github.com>
    Co-authored-by: francinelucca <francinelucca@users.noreply.github.com>
    Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
    Co-authored-by: Randall Krauskopf <104226843+randall-krauskopf@users.noreply.github.com>
    Co-authored-by: randall-krauskopf <randall-krauskopf@users.noreply.github.com>
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    Co-authored-by: hussam-i-am <hussam-i-am@users.noreply.github.com>
    9 people authored Dec 18, 2024
    Copy the full SHA
    b07f806 View commit details
  2. Deprecate use of sx prop by deprecating the SxProp type definition (#…

    …5443)
    
    * Use DeprecatedSxProp instead of SxProp
    
    * Create few-coins-kick.md
    
    * Fix typo in changeset description
    
    * Use SxProp and deprecate that instead
    
    * Fix typo in changeset description
    
    * Fix typo in changeset description
    jonrohan authored Dec 18, 2024
    Copy the full SHA
    f03ae58 View commit details
  3. feat(ActionList sub components) Convert to CSS Modules (#5398)

    * copy
    
    * copy all
    
    * fix padding
    
    * add heading
    
    * fix selectpanel story
    
    * vrt
    
    * alignment
    
    * moar fixes
    
    * dev stories
    
    * tests
    
    * moving tests around
    
    * tests
    
    * tests
    
    * Apply suggestions from code review
    
    * prettier
    
    * lint
    
    * test(vrt): update snapshots
    
    * fix nesting issue
    
    * reset
    
    * test(vrt): update snapshots
    
    * vrt
    
    * cleanup
    
    * reset
    
    * test(vrt): update snapshots
    
    * very sad and annoying
    
    * snaps
    
    * Create dirty-nails-applaud.md
    
    * reduce margin on divider
    
    * remove truncation e2e test
    
    * snappers
    
    * lint
    
    * test(vrt): update snapshots
    
    * fix navlist group
    
    * Update packages/react/src/ActionList/Visuals.tsx
    
    Co-authored-by: Josh Black <joshblack@github.com>
    
    * test classname on visuals
    
    * add e2e
    
    * use common ff
    
    * feat(NavList) Convert to CSS Modules (#5424)
    
    * navlist
    
    * fix sub item
    
    * fix margin
    
    * fixies
    
    * Create quick-items-hunt.md
    
    * not sure how to make this test pass
    
    * prettier
    
    * logging test failure
    
    * reset
    
    * test(vrt): update snapshots
    
    * remove flaky test
    
    * fix changeset
    
    * fix active color var
    
    * big oops
    
    * remove transitions for now
    
    * haha
    
    * fix trailing visual as text + add test
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    Co-authored-by: Josh Black <joshblack@github.com>
    3 people authored Dec 18, 2024
    Copy the full SHA
    215d8e6 View commit details
  4. Copy the full SHA
    300c3b9 View commit details

Commits on Dec 19, 2024

  1. chore(deps): update @primer/octicons-react to 19.13.0 (#5456)

    * bump
    
    * fix paths
    
    * Create proud-phones-repeat.md
    
    * test(vrt): update snapshots
    
    * revert
    
    * reset
    
    * force to 13
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    langermank and langermank authored Dec 19, 2024
    Copy the full SHA
    e990fdb View commit details
  2. Implement code connect for segmentedControl and heading (#4849)

    * implement code connect for segmentedControl
    
    * add AI icon
    
    * rebase main
    
    * wip
    
    * Update jest snapshots
    
    * test(vrt): update snapshots
    
    * Package updates/revert
    
    * Add another bump for needed icon
    
    * revert octicons
    
    * reset
    
    * reset snapshots
    
    * test(vrt): update snapshots
    
    * reset
    
    * snaps
    
    ---------
    
    Co-authored-by: Tyler Jones <tylerjdev@github.com>
    Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>
    Co-authored-by: lukasoppermann <lukasoppermann@users.noreply.github.com>
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    5 people authored Dec 19, 2024
    Copy the full SHA
    83386f4 View commit details
  3. refactor(FormControl): update FormControl to use CSS Modules behind f…

    …lag (#5438)
    
    * refactor: move form control test files into folder
    
    * refactor(FormControl): update FormControl to use CSS Modules behind flag
    
    * refactor(InputLabel): update InputLabel to use CSS Modules behind feature flag
    
    * refactor(FormControl): update Caption to use CSS Modules behind feature flag
    
    * refactor(InputValidation): refactor InputValidation to CSS Modules behind feature flag
    
    * chore: add changeset
    
    * Apply suggestions from code review
    
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    
    * chore: update stylelint violations
    
    * fix: update selector for leading visual
    
    * add missing sx prop
    
    ---------
    
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    Co-authored-by: Hussam Ghazzi <hussam-i-am@github.com>
    3 people authored Dec 19, 2024
    Copy the full SHA
    4776d13 View commit details
  4. Add stories for Octicon usage (#5244)

    * add stories
    
    * fix sidebar
    langermank authored Dec 19, 2024
    Copy the full SHA
    e1808ec View commit details
  5. feat(Autocomplete): Convert Box usage to CSS modules behind feature f…

    …lag (#5451)
    
    * test(AutoComplete): add e2e tests
    
    * test(vrt): update snapshots
    
    * fix(Autocomplete): wait for full render before e2e testing
    
    * test(vrt): update snapshots
    
    * fix dev storybook accessibility
    
    * fix lint
    
    * fix theme related a11y errors
    
    * test(vrt): update snapshots
    
    * ignore color-contrast rule
    
    * initial commit
    
    * remove unused snapshots
    
    * remove file
    
    * revert file
    
    * format fix
    
    * changeset
    
    ---------
    
    Co-authored-by: Marie Lucca <francinelucca@github.com>
    Co-authored-by: francinelucca <francinelucca@users.noreply.github.com>
    Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
    Co-authored-by: randall-krauskopf <randall-krauskopf@users.noreply.github.com>
    Co-authored-by: Hussam Ghazzi <hussam-i-am@github.com>
    6 people authored Dec 19, 2024
    Copy the full SHA
    59a1346 View commit details
  6. add extension (#5465)

    langermank authored Dec 19, 2024
    Copy the full SHA
    3f68caf View commit details
  7. Corrects styling on Buttons that only have a count and icon (#5448

    )
    
    * adds 'count' prop to IconButton
    
    * adds VRT for IconButton with trailing counter
    
    * updates IconButton component API docs
    
    * adds changeset
    
    * test(vrt): update snapshots
    
    * adds 'count' to IconButton Playground story
    
    * addresses feedback to modify component API
    
    * modifies changeset
    
    * reverts new IconButton VRT
    
    * reverts new IconButton stories
    
    * test(vrt): update snapshots
    
    * appeases the linter
    
    * add vrt
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: mperrotti <mperrotti@users.noreply.github.com>
    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    Co-authored-by: langermank <langermank@users.noreply.github.com>
    4 people authored Dec 19, 2024
    Copy the full SHA
    00600f7 View commit details
  8. chore(Select): Remove CSS modules feature flag from Select (#5464)

    * Remove CSS modules feature flag from Select
    
    * Create violet-tables-eat.md
    jonrohan authored Dec 19, 2024
    Copy the full SHA
    d43f27f View commit details
  9. refactor(Table): update to CSS Modules (#5435)

    * refactor(Table): update to CSS Modules
    
    * chore: add changeset
    
    * chore: update import for css module classes
    
    * chore: fix stylelint errors
    
    * fix: update type tokens used for Table
    
    * chore: disable stylelint rule for custom line height
    
    * test(vrt): update snapshots
    
    * Revert "test(vrt): update snapshots"
    
    This reverts commit a7ddd68.
    
    * Fix subtitle lineheight to match VRT
    
    * Add missing Button styles
    
    * Fix lineheight when feature flag is on
    
    ---------
    
    Co-authored-by: Jon Rohan <yes@jonrohan.codes>
    Co-authored-by: jonrohan <jonrohan@users.noreply.github.com>
    Co-authored-by: Stephanie Hong <41085564+JelloBagel@users.noreply.github.com>
    4 people authored Dec 19, 2024
    Copy the full SHA
    5cba52a View commit details
  10. chore(Skeleton): Remove the CSS module feature flag from Skeleton (#5461

    )
    
    * Remove the CSS module feature flag from Skeleton
    
    * Create thirty-wasps-sleep.md
    jonrohan authored Dec 19, 2024
    Copy the full SHA
    9bd2f79 View commit details
  11. chore(Header): Remove CSS modules feature flag from Header (#5460)

    * Remove CSS modules feature flag from Header
    
    * Adjust Header for as prop
    
    * Create shaggy-comics-whisper.md
    jonrohan authored Dec 19, 2024
    Copy the full SHA
    6d70d1b View commit details

Commits on Dec 26, 2024

  1. chore(deps): bump next from 14.2.10 to 14.2.15 (#5455)

    Bumps [next](https://github.com/vercel/next.js) from 14.2.10 to 14.2.15.
    - [Release notes](https://github.com/vercel/next.js/releases)
    - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
    - [Commits](vercel/next.js@v14.2.10...v14.2.15)
    
    ---
    updated-dependencies:
    - dependency-name: next
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
    dependabot[bot] and francinelucca authored Dec 26, 2024
    Copy the full SHA
    87cf3b2 View commit details

Commits on Dec 30, 2024

  1. ActionBar: Ensure overflow menu only exists if there is no space (#5476)

    * Ensure items in menu leave menu if there is space
    
    * Fixes initial check for if menu items should have overflow menu or not; adds new story
    
    * Add changeset
    
    * Fix stories file structure
    
    * Fix ID
    
    * Remove redundant check
    TylerJDev authored Dec 30, 2024
    Copy the full SHA
    578a33d View commit details
  2. fix(PageLayout): Remove unused width value in PageLayout.Pane (#5484)

    * fix(PageLayout): Remove unused width pabe value
    
    * remove unused value
    
    * css
    hussam-i-am authored Dec 30, 2024
    Copy the full SHA
    efb1659 View commit details

Commits on Jan 3, 2025

  1. fix: Set static date in DataTable feature stories (#5487)

    * TEST
    
    * test(vrt): update snapshots
    
    * Fix README.md formatting issue
    
    * fix: set static date for datatable story
    
    * test(vrt): update snapshots
    
    ---------
    
    Co-authored-by: francinelucca <francinelucca@users.noreply.github.com>
    francinelucca and francinelucca authored Jan 3, 2025
    Copy the full SHA
    51065d6 View commit details
  2. test: add check for story ids in generated docs (#5441)

    * test: add check for story ids in generated docs
    
    * merge with main
    
    * fix: script path
    
    * fix: script path
    
    * fix: IconButton story id
    
    * fix: IconButton story id
    
    * fix: Hidden story id
    
    * Create hungry-mugs-stare.md
    
    * fix: InlineMessage story id
    
    * update Portal story docs
    
    * update TooltipV2 story docs
    
    * Revert "merge with main"
    
    This reverts commit 577bc64.
    
    * deps: package-lock fix
    
    ---------
    
    Co-authored-by: Marie Lucca <francinelucca@github.com>
    Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
    3 people authored Jan 3, 2025
    Copy the full SHA
    30e8c31 View commit details
  3. update figma code connect dependency (#5454)

    * update figma code connect dependency
    
    * trying to fix package-lock
    
    * Add override for `nwsapi`
    
    ---------
    
    Co-authored-by: Tyler Jones <tylerjdev@github.com>
    lukasoppermann and TylerJDev authored Jan 3, 2025
    Copy the full SHA
    8ce1a7a View commit details

Commits on Jan 6, 2025

  1. chore(deps-dev): bump storybook from 8.3.0 to 8.4.7 (#5474)

    Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) from 8.3.0 to 8.4.7.
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.7/code/lib/cli)
    
    ---
    updated-dependencies:
    - dependency-name: storybook
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 6, 2025
    Copy the full SHA
    9fa9785 View commit details
  2. chore(deps-dev): bump @storybook/addon-actions from 8.3.0 to 8.4.7 (#…

    …5473)
    
    Bumps [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions) from 8.3.0 to 8.4.7.
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.7/code/addons/actions)
    
    ---
    updated-dependencies:
    - dependency-name: "@storybook/addon-actions"
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 6, 2025
    Copy the full SHA
    bf5825e View commit details
  3. chore(deps-dev): bump eslint-plugin-storybook from 0.8.0 to 0.11.2 (#…

    …5491)
    
    Bumps [eslint-plugin-storybook](https://github.com/storybookjs/eslint-plugin-storybook) from 0.8.0 to 0.11.2.
    - [Release notes](https://github.com/storybookjs/eslint-plugin-storybook/releases)
    - [Changelog](https://github.com/storybookjs/eslint-plugin-storybook/blob/main/CHANGELOG.md)
    - [Commits](storybookjs/eslint-plugin-storybook@v0.8.0...v0.11.2)
    
    ---
    updated-dependencies:
    - dependency-name: eslint-plugin-storybook
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 6, 2025
    Copy the full SHA
    e978743 View commit details
  4. Revert "refactor(FormControl): update FormControl to use CSS Modules …

    …behind f…" (#5494)
    
    This reverts commit 4776d13.
    francinelucca authored Jan 6, 2025
    Copy the full SHA
    43afd36 View commit details
  5. Copy the full SHA
    23d77f8 View commit details
  6. Copy the full SHA
    586083a View commit details
  7. Copy the full SHA
    d43c6c9 View commit details

Commits on Jan 7, 2025

  1. Version Packages (#5439)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    primer[bot] and github-actions[bot] authored Jan 7, 2025
    Copy the full SHA
    ee16256 View commit details
Loading