Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): #7335 #7352

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

AkifAycicek
Copy link
Contributor

@AkifAycicek AkifAycicek commented Feb 28, 2025

When groupRowsBy is set to rowspan and row expansion is enabled, the last rows in a group would shift left. This was caused by the hidden columns defined in groupRowsBy. The issue became more noticeable as more rows were expanded. This fix ensures consistent table layout regardless of row expansion.

Fixes #7335

Unverified

This user has not yet uploaded their public signing key.
When `groupRowsBy` is set to `rowspan` and row expansion is enabled, the last rows in a group would shift left. This was caused by the hidden columns defined in `groupRowsBy`. The issue became more noticeable as more rows were expanded. This fix ensures consistent table layout regardless of row expansion.
Copy link

vercel bot commented Feb 28, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@tugcekucukoglu
Copy link
Member

Please create an issue while submitting PR.

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 4, 2025
@AkifAycicek
Copy link
Contributor Author

Hi @tugcekucukoglu , the related issue was #7335

@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 6, 2025
@tugcekucukoglu tugcekucukoglu merged commit b436c35 into primefaces:master Mar 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Table layout shifts when groupRowsBy is rowspan and row expansion is enabled
2 participants