[CARE-5792] Fix - Rework Table element to not rely on context #89
Conversation
|
Hey @yuriyyakym, I've reworked the approach to use the transformation as suggested. Looks much better now I think. |
kudlajz
deleted the
feature/care-5792-refactor-table-component-in-content-renderer
branch
| export namespace TableCell { | ||
| export type Node = TableCellNode & { isHeader: boolean }; |
There was a problem hiding this comment.
By the way, I had a similar challenge in the React emails project, and managed to solve it without extending the model:
There was a problem hiding this comment.
I wanted to do it the same way you did, by having a single Table component and rendering everything inside, but the problem was the way Renderer component is implemented, where it iterates over every node in the document and then renders the component that matches.
I think in order to implement it like you did, we would have to change the whole renderer (or maybe change the Renderer to only iterate over top-level nodes) and then have the top-level components render their children separately.
No description provided.