fix :: in call expr comment causing crash #8117
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7748
Prettier crashed when
::
appeared in a call expression. This PR is supposed to fix that. The error is due to Prettier (wrongly) assuming that the comment is a Flow annotation. I have added a check against empty flow annotations which fixes it.However, I can't seem to get the tests to pass. I have manually tested with both the CLI & the API (with all parsers) and it works. The playground works too but when I run the test suite with
x(/* :: */[]);
input, prettier automatically erases the comment. Don't know why. This happens even without my changes. @thorn0 would appreciate any help 😄docs/
directory)changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨