Fixes #5446 Do not convert type parameter to comment type #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could somebody review or should I close it includes non-ideal solution ❓ |
|
Did I break it? |
|
@fisker Go ahead |
|
superseded by #13687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5446
When once comment type of Flow occurred at the code, unintentional converting from type parameter like
A<B>toA/*:: <B> */applied.As commented at here, due to lack of information whether the current node declared internal comment type or not, differences this PR proposed to do not fully ideal.
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨