Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument passed to lilconfig.search() #15363

Merged
merged 12 commits into from Nov 15, 2023
Merged

Fix argument passed to lilconfig.search() #15363

merged 12 commits into from Nov 15, 2023

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Sep 7, 2023

Description

It should search from dirname of the file.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Sponsor Member Author

fisker commented Sep 7, 2023

Somehow we support --find-config-path for directory...

@fisker fisker closed this Sep 7, 2023
@fisker fisker deleted the lilconfig-search branch September 7, 2023 02:44
@pmdartus pmdartus mentioned this pull request Nov 13, 2023
Open
@fisker fisker restored the lilconfig-search branch November 15, 2023 13:04
@fisker fisker reopened this Nov 15, 2023
@fisker fisker merged commit e4a74c0 into prettier:main Nov 15, 2023
28 checks passed
@fisker fisker deleted the lilconfig-search branch November 15, 2023 17:05
@rmehner rmehner mentioned this pull request Dec 11, 2023
Closed
@fisker fisker mentioned this pull request Jan 5, 2024
Closed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
@fisker @medikoo
Fix argument passed to lilconfig.search() (prettier#15363)
6f37fbf
@agreedSkiing agreedSkiing mentioned this pull request Mar 4, 2024
Closed
@sosukesuzuki sosukesuzuki mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fisker