Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build script --report option #15323

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Fix build script --report option #15323

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1a17d7
Fix property name typo
sosukesuzuki Aug 29, 2023
27dfc33
Remove `--report` shortcut
sosukesuzuki Aug 29, 2023
87a1145
Update build-javascript-module.js
fisker Aug 29, 2023
297fa8a
Update parse-arguments.js
fisker Aug 29, 2023
4e7060b
Update parse-arguments.js
fisker Aug 29, 2023
5da8878
Typo
fisker Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions scripts/build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ yarn build --report=all
yarn build --report=stdout --report=text --report=html
```

**`--report` equals to `--report=html`**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to make it happen with node:utils.parsArgs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't work anymore, you can use --report=all


### `--minify` and `--no-minify`

By default, the file minification is controlled by `config.mjs` and `bundler.mjs`, these flags are added to override that behavior.
Expand Down
4 changes: 2 additions & 2 deletions scripts/build/build-javascript-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ function getEsbuildOptions({ file, files, shouldCollectLicenses, cliOptions }) {
output: (dependencies) => file.dependencies.push(...dependencies),
},
}),
cliOptions.reports &&
esbuildPluginVisualizer({ formats: cliOptions.reports }),
cliOptions.report &&
fisker marked this conversation as resolved.
Show resolved Hide resolved
esbuildPluginVisualizer({ formats: cliOptions.report }),
esbuildPluginThrowWarnings({
allowDynamicRequire: file.platform === "node",
allowDynamicImport: file.platform === "node",
Expand Down