New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print declare
and export
keywords for nested namespace
#15249
Conversation
"@typescript-eslint/typescript-estree": "6.3.0", | ||
"@typescript-eslint/visitor-keys": "6.3.0", | ||
"@typescript-eslint/typescript-estree": "6.4.0", | ||
"@typescript-eslint/visitor-keys": "6.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you upgrade @typescript-eslint/eslint-plugin
too? So the dependencies doesn't get duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 5cdb8a6
|
||
export namespace abc3.def.ghi {} | ||
|
||
namespace abc4.def.ghi {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also replace namespace
with module
keyword, and test them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 4c60892
This is regression fix so I'll release patch after merging this. |
Description
Fixes #15207
Checklist
changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨