Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shared config that forbids require() #15233

Merged
merged 5 commits into from Aug 29, 2023
Merged

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 11, 2023

Description

Fixes #15195

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review August 11, 2023 09:56
@fisker
Copy link
Member Author

fisker commented Aug 29, 2023

@sosukesuzuki Can you review? We can include this in patch release.

Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisker fisker merged commit a35008f into prettier:main Aug 29, 2023
29 checks passed
@fisker fisker deleted the 15195 branch August 29, 2023 08:11
@Hulmey
Copy link

Hulmey commented Aug 29, 2023

@sosukesuzuki Can you review? We can include this in patch release.

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier 3.x - Package subpath is not defined
3 participants