Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add trailing comma for grouped scss comments #15217

Merged
merged 2 commits into from Aug 11, 2023
Merged

Do not add trailing comma for grouped scss comments #15217

merged 2 commits into from Aug 11, 2023

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Aug 6, 2023 •
edited

Description

Fixes #15193

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@sosukesuzuki sosukesuzuki merged commit 8a3e73c into prettier:main Aug 11, 2023
29 checks passed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
@auvred @medikoo
Do not add trailing comma for grouped scss comments (prettier#15217)
e05db04 
* Do not add trailing comma for grouped scss comments

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected trailing comma in comments for scss file
3 participants
@auvred @fisker @sosukesuzuki