New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parenthesis around leading multiline comment in return statement #15037

Merged

sosukesuzuki merged 3 commits into prettier:main from auvred:fix/15013

Jul 16, 2023

Contributor

auvred commented Jul 8, 2023 •

edited

Description

Fixes #15013

There is no such problem with JSX (playground), so I excluded it from the condition to avoid duplicate parenthesis

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

auvred added 2 commits

July 8, 2023 09:07


          fix: add parenthesis around leading multiline comment in return state…

a00c893

…ment


          replace .includes("\n") by hasNewlineInRange

8807e1e

700software mentioned this pull request

jsdoc comment parenthesis removal breaks return in some case #15013

Closed


          add changelog

fe6109d

fisker approved these changes

View reviewed changes

sosukesuzuki approved these changes

View reviewed changes

sosukesuzuki merged commit 8da37cc into prettier:main

29 checks passed

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request


          Add parenthesis around leading multiline comment in return statement (p…

ad30ded

…rettier#15037)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment