Make haml/rbs dependencies optional

[mikesea]

👋 Hey, thanks for this plugin.

Right now this plugin requires you to install the dependencies for formatting haml and rbs files, even if your codebase isn't using those types of files. This PR modifies src/server.rb so these formatting dependencies are only required "on demand" - e.g., when the server is actually processing a haml or rbs file only required optionally.

This change will mean we can drop haml as a dependency in our codebase, since it's only being imported so that we can format ruby files with this plugin.

[kddnewton]

Hi @mikesea! Thanks for the contribution. I can totally see where you're coming from.

I don't want to call require on every file being formatted. Could we instead only require at the top of the file but rescue LoadError for the ones that should be optional? That way they still wouldn't be "required" but it wouldn't slow down individual requests once the server is booted.

[kddnewton]

Also you should rebase, main was broken, but it's been fixed now.

[kddnewton]

Just marking this as "request changes"

[mikesea]

@kddnewton makes sense, done!

[kddnewton]

@mikesea looks like you just need to run prettier on server.rb now

[mikesea]

looks like you just need to run prettier on server.rb now

🤦

@kddnewton sorry about that, done!

[langalex]

woudln't you also need to remove the dependencies from the gemspec? as it is, the gems are still installed since they are listed there.

[mikesea]

It depends how you're using this plugin. We're invoking it via prettier in npm, so the Ruby dependencies need to be installed manually. But that's a good point, if you're using this as a gem, these dependencies should be marked as optional in the gemspec for them to not get installed.