Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing markdown via eslint-mdx natively #621

Merged
merged 1 commit into from Dec 24, 2023

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 21, 2023

The following is unnecessary anymore when using with eslint-mdx/eslint-plugin-mdx!

[
  {
    files: ["**/*.md"],
    rules: { "prettier/prettier": ["error", { parser: "markdown" }] },
  },
  {
    files: ["**/*.mdx"],
    rules: { "prettier/prettier": ["error", { parser: "mdx" }] },
  },
]

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 535c3af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-prettier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JounQin JounQin changed the title feat: support parsing markdown via eslint-mdx natively feat: support parsing markdown via eslint-mdx natively Dec 21, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 21, 2023

We can also support other HTML related ESLint plugins like https://github.com/yeonjuan/html-eslint or https://github.com/un-ts/eslint/tree/main/packages/markup

@JounQin
Copy link
Member Author

JounQin commented Dec 21, 2023

@BPScott Any time to review?

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Does this change mean older versions of any packages will stop working or is this a purely forwards-compatible change? I'm wondering if we need to call any "You should update this other package" stuff in the changeset

Added a few polishing thoughts inline as the changeset prettierrc, package patches and dependency changes seem unrelated to the changes to the worker.

.changeset/.prettierrc Outdated Show resolved Hide resolved
patches/@graphql-eslint__eslint-plugin@3.20.0.patch Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@JounQin
Copy link
Member Author

JounQin commented Dec 22, 2023

@BPScott This PR is totally backwards/forwards compatible and won't break anything. It's a minor enhancement.

@JounQin JounQin requested a review from BPScott December 23, 2023 08:44
@JounQin JounQin merged commit 2b09e7f into master Dec 24, 2023
4 checks passed
@JounQin JounQin deleted the feat/eslint-mdx branch December 24, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants