Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restoring cache for pyproject.toml #95

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Apr 11, 2024

No description provided.

@nichmor nichmor marked this pull request as ready for review April 11, 2024 07:07
@nichmor nichmor requested a review from pavelzw as a code owner April 11, 2024 07:07
Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix. In general, we should make sure, though, that setup-pixi works out of the box if only a pyproject.toml is present without specifying manifest-path.

@nichmor can you bump the patch version in package.json? Then the release pipeline will be triggered automatically once merged.

test/pyproject-manifest/pyproject.toml Outdated Show resolved Hide resolved
@pavelzw pavelzw added the bug Something isn't working label Apr 11, 2024
@pavelzw
Copy link
Collaborator

pavelzw commented Apr 11, 2024

Let's wait for #94 with merging, then we can release two fixes at once.

@pavelzw
Copy link
Collaborator

pavelzw commented Apr 11, 2024

Closes #93

@nichmor
Copy link
Contributor Author

nichmor commented Apr 11, 2024

LGTM as a quick fix. In general, we should make sure, though, that setup-pixi works out of the box if only a pyproject.toml is present without specifying manifest-path.

@nichmor can you bump the patch version in package.json? Then the release pipeline will be triggered automatically once merged.

Hey!
Yeah, totally. I just wanted to make the scope of this PR very small and later maybe work on automatic discovery of pyproject manifest.
Let me bump the patch version

@nichmor
Copy link
Contributor Author

nichmor commented Apr 11, 2024

bumped.
@pavelzw can I merge it?

@pavelzw
Copy link
Collaborator

pavelzw commented Apr 11, 2024

let's wait for CI and then we can merge it 馃憤馃徎

@pavelzw pavelzw enabled auto-merge (squash) April 11, 2024 12:59
@pavelzw pavelzw disabled auto-merge April 11, 2024 13:28
@pavelzw pavelzw merged commit 4fc8d82 into main Apr 11, 2024
67 of 102 checks passed
@pavelzw pavelzw deleted the fix/restoring-cache-with-pyproject-toml branch April 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants