-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#923 Make MasterSlaveReplication iterable by extending AbstractConnection #934
base: v2.x
Are you sure you want to change the base?
#923 Make MasterSlaveReplication iterable by extending AbstractConnection #934
Conversation
throw new \RuntimeException('Not implemented.'); | ||
} | ||
|
||
protected function getIdentifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a test for this on the MasterSlaveReplication
.
|
||
protected function createResource() | ||
{ | ||
throw new \RuntimeException('Not implemented.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MInor: Use FQDN
@@ -268,12 +268,12 @@ public function testDisconnectForcesCurrentConnectionToDisconnect(): void | |||
{ | |||
$master = $this->getMockConnection('tcp://127.0.0.1:6379?role=master'); | |||
$master | |||
->expects($this->once()) | |||
->expects($this->exactly(2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't call disconnect twice.
Fixes #923