Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for hash field expiration commands #1456

Open
wants to merge 14 commits into
base: v2.x
Choose a base branch
from
Open

Added support for hash field expiration commands #1456

wants to merge 14 commits into from

Conversation

vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented Apr 29, 2024 •
edited

This PR adds new commands operates on hash field expiration functionality

@vladvildanov vladvildanov requested review from tillkruss and a team as code owners April 29, 2024 12:37
@vladvildanov vladvildanov marked this pull request as draft April 29, 2024 12:37
@vladvildanov
Copy link
Contributor Author

vladvildanov commented Apr 29, 2024 •
edited

PR still on draft, until:

  • Redis unstable docker image will support given functionality

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited

Coverage Status

coverage: 80.384% (+0.1%) from 80.289%
when pulling 4c8f16d on vladvildanov:vv-hash-field-expiration
into cbef710 on predis:v2.x.

gerzse
gerzse reviewed May 17, 2024
View reviewed changes
src/ClientContextInterface.php Outdated Show resolved Hide resolved
src/Command/Argument/Hash/CommonExpiration.php Outdated Show resolved Hide resolved
src/Command/Argument/Hash/CommonExpiration.php Outdated Show resolved Hide resolved
src/Command/Argument/Hash/HGetFArguments.php Outdated Show resolved Hide resolved
src/Command/Redis/HEXPIRETIME.php Show resolved Hide resolved
src/Connection/Replication/MasterSlaveReplication.php Outdated Show resolved Hide resolved
gerzse
gerzse reviewed May 21, 2024
View reviewed changes
Copy link

@gerzse gerzse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't use the "Approve" button, but consider this approved from my side.

@vladvildanov vladvildanov marked this pull request as ready for review June 11, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerzse gerzse gerzse left review comments

@sazzad16 sazzad16 sazzad16 left review comments

@tillkruss tillkruss Awaiting requested review from tillkruss tillkruss is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vladvildanov @coveralls @gerzse @sazzad16