Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mkdirp to latest version #115

Closed
wants to merge 2 commits into from
Closed

Update mkdirp to latest version #115

wants to merge 2 commits into from

Conversation

shahar-h
Copy link

Current mkdirp version is using minimist 0.0.8, which has a security vulnerability.
mkdirp > 1.00 doesn't use minimist anymore so upgarding will resolve this issue.

@shahar-h
Update mkdirp to latest version
7f276f9 
Current `mkdirp` version is using `minimist` 0.0.8, which has a security [vulnerability](https://snyk.io/vuln/SNYK-JS-MINIMIST-559764).
`mkdirp` > 1.00 doesn't use `minimist` anymore so upgarding will resolve this issue.
@shahar-h
Change callbacks to promises
6ad35e1
@vweevers
Copy link
Member

minimist is only used when you use mkdirp as a CLI, rather than a module. So the vulnerability does not apply.

@shahar-h
Copy link
Author

shahar-h commented Mar 17, 2020 •
edited

a new version of mkdirp 0.5.3 was released with an upgrade to minimist, so security issue should be resolved with this upgrade:
isaacs/node-mkdirp#7

@shahar-h shahar-h closed this Mar 17, 2020
@shahar-h shahar-h deleted the patch-1 branch March 17, 2020 20:27
@vweevers vweevers mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahar-h @vweevers