More perf improvements #232
Merged
+1,630
−800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d2cf76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
|
|
||
| // account for >1 multiline attribute | ||
| if (pretty) { |
There was a problem hiding this comment.
My guess is that this is always true since this whole function is now the pretty printing path.
There was a problem hiding this comment.
heh I should rename this as I am doing
if (
opts.pretty ||
opts.sortAttributes ||
opts.shallow ||
opts.allAttributes ||
opts.xml ||
opts.attributeHook
) {
To get to this code path 😅 wanted to create a very hot-path for optimized string-rendering
marvinhagemeister
approved these changes
Jul 24, 2022
* speed up entity encoding * use constants for mangle props, remove opts intermediary, collapse helper functions (not as sure on that one), inline fragment rendering. * slight improvement to the d8 bench runner * add color picker bench
This was referenced Aug 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.